Merged
Conversation
timcassell
force-pushed
the
in-process-diagnosers
branch
from
e97b525 to
34ed698
Compare
timcassell
force-pushed
the
in-process-diagnosers
branch
from
83912f1 to
3ad6a27
Compare
timcassell
commented
Oct 29, 2025
Collaborator
Author
|
It works nicely, but I'm not entirely sold on this design of diagnosers creating source code tied to C#. An alternative is serializing ctor data. I would love to use static interface members for this, but sadly they aren't supported on netstandard2.0. 😞 @AndreyAkinshin Any thoughts? |
Member
|
@adamsitnik could you please take a look? |
Collaborator
Author
|
I changed it so diagnosers return Type and serialized config instead of source code. I think source code generation should be left to the toolchains. |
timcassell
force-pushed
the
in-process-diagnosers
branch
from
ef14209 to
eb27f66
Compare
Collaborator
Author
|
@copilot Add tests for multiple in-process diagnosers with varying run modes. |
Contributor
|
@timcassell I've opened a new pull request, #2857, to work on those changes. Once the pull request is ready, I'll request review from you. |
22 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
timcassell
force-pushed
the
in-process-diagnosers
branch
from
d04dd1a to
ff20126
Compare
Make DisassemblyDiagnoser run in-process by default. Revert x86 test workaround and add tests.
…2857) Add extensive InProcessDiagnoserTests.
Return `InProcessDiagnoserHandlerData` type instead of tuple.
timcassell
force-pushed
the
in-process-diagnosers
branch
from
ff20126 to
7dca372
Compare
# Conflicts: # src/BenchmarkDotNet/BenchmarkDotNet.csproj
filzrev
reviewed
Dec 3, 2025
This was referenced Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IInProcessDiagnoserinterface.DisassemblyDiagnoseris the first in-process diagnoser (with the option to run in host for back-compat).test-windows-fullCI job failed on disassemble tests for x86 #2789